Adding basic dynamic mode #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rialization ScheduleExchange messages tests Signed-off-by: Sebastian Lukas <[email protected]>
Signed-off-by: Sebastian Lukas <[email protected]>
…arge_dynamic_mode to feedback Signed-off-by: Sebastian Lukas <[email protected]>
Signed-off-by: Sebastian Lukas <[email protected]>
…mobilityneeds (1 and 2) modes in the EvseSetupConfig struct Signed-off-by: Sebastian Lukas <[email protected]>
Signed-off-by: Sebastian Lukas <[email protected]>
Signed-off-by: Sebastian Lukas <[email protected]>
…needs_mode support to schedule_exchange & dc_charge_loop, adding dc_charge_loop states test Signed-off-by: Sebastian Lukas <[email protected]>
Signed-off-by: Sebastian Lukas <[email protected]>
3 tasks
a-w50
requested changes
Oct 21, 2024
| static constexpr auto SCHEDULED_POWER_DURATION_S = 86400; | ||
|
|
||
| Header header; | ||
| ResponseCode response_code; | ||
|
|
||
| ScheduleExchangeResponse() : | ||
| processing(Processing::Finished), control_mode(std::in_place_type<Dynamic_SEResControlMode>){}; | ||
| processing(Processing::Finished), control_mode(std::in_place_type<Dynamic_SEResControlMode>) {}; |
There was a problem hiding this comment.
We should use default values for the member variables right away, not defining custom constructors
There was a problem hiding this comment.
I have no preference. So I can change this in a separate PR for all message definitions.
Signed-off-by: Sebastian Lukas <[email protected]>
Signed-off-by: Sebastian Lukas <[email protected]>
Signed-off-by: Sebastian Lukas <[email protected]>
Signed-off-by: Sebastian Lukas <[email protected]>
Signed-off-by: Sebastian Lukas <[email protected]>
Signed-off-by: Sebastian Lukas <[email protected]>
…amicModeParameters struct instead of the 3 individual variables Signed-off-by: Sebastian Lukas <[email protected]>
Signed-off-by: Sebastian Lukas <[email protected]>
Signed-off-by: Sebastian Lukas <[email protected]>
Signed-off-by: Sebastian Lukas <[email protected]>
Signed-off-by: Sebastian Lukas <[email protected]>
a-w50
approved these changes
Nov 8, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds basic support for dynamic mode. Tested on the Testival in France and there was no problems.
Issue ticket number and link
Support for dynamic mode was missing
Checklist before requesting a review